ksmith/OrbitWard
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Add tests for website monitor and notification flows #10

New Issue
Closed
opened 2026-05-22 17:44:18 -06:00 by Agent · 2 comments
Agent commented 2026-05-22 17:44:18 -06:00
Copy Link
Copy Source

Add backend and worker tests covering website monitor creation, check result storage, incident open/recovery, encrypted notification channels, and webhook payloads.

Add backend and worker tests covering website monitor creation, check result storage, incident open/recovery, encrypted notification channels, and webhook payloads.
Agent commented 2026-05-23 16:14:47 -06:00
Author
Copy Link
Copy Source

Partial backend coverage implemented in 68d5e0a.

Summary:

  • Added SQLite-backed API test fixtures with authenticated owner override.
  • Added website monitor tests covering asset creation, TLS config persistence, default alert rule creation, and disabled default alerts.
  • Added notification channel tests verifying webhook URLs are encrypted and not returned by create/list/update responses.
  • Updated progress docs to note remaining worker alert-evaluation and notification-delivery test coverage.

Verified:

  • docker compose exec -T backend pytest

Current result: 5 passed, 1 warning. Warning tracked separately as #17.

Partial backend coverage implemented in 68d5e0a. Summary: - Added SQLite-backed API test fixtures with authenticated owner override. - Added website monitor tests covering asset creation, TLS config persistence, default alert rule creation, and disabled default alerts. - Added notification channel tests verifying webhook URLs are encrypted and not returned by create/list/update responses. - Updated progress docs to note remaining worker alert-evaluation and notification-delivery test coverage. Verified: - docker compose exec -T backend pytest Current result: 5 passed, 1 warning. Warning tracked separately as #17.
Agent commented 2026-05-23 19:51:56 -06:00
Author
Copy Link
Copy Source

Completed remaining worker coverage in 19d4c6e.

Summary:

  • Added worker scheduler tests for alert threshold incident opening.
  • Added recovery resolution coverage.
  • Added notification history/deduplication coverage.
  • Added alert cooldown coverage.
  • Fixed cooldown timestamp comparison to normalize incident timestamps to UTC, which keeps SQLite-backed tests and timezone-aware runtime comparisons consistent.
  • Updated progress docs.

Verified:

  • docker compose exec -T worker python -m unittest discover -s tests
  • docker compose exec -T backend pytest

Current backend warning remains tracked separately as #17.

Completed remaining worker coverage in 19d4c6e. Summary: - Added worker scheduler tests for alert threshold incident opening. - Added recovery resolution coverage. - Added notification history/deduplication coverage. - Added alert cooldown coverage. - Fixed cooldown timestamp comparison to normalize incident timestamps to UTC, which keeps SQLite-backed tests and timezone-aware runtime comparisons consistent. - Updated progress docs. Verified: - docker compose exec -T worker python -m unittest discover -s tests - docker compose exec -T backend pytest Current backend warning remains tracked separately as #17.
Agent closed this issue 2026-05-23 19:51:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ksmith
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ksmith/OrbitWard#10
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?